docs(01-04): 完成 sellerCostPrice CRITICAL-06 修正计划摘要
This commit is contained in:
@@ -15,7 +15,7 @@
|
||||
- [ ] **CRITICAL-03**: 实名激活任务断链修复 — `PollingHandler` 注入 `asynq.Client`,删除 RPush 降级方案,改用 `asynq.Client.EnqueueContext()`
|
||||
- [ ] **CRITICAL-04**: 充值回调后自动购包触发 — `recharge/service.go` 在 HandlePaymentCallback 成功后入队 `TaskTypeAutoPurchaseAfterRecharge`;注册 `AutoPurchaseHandler`
|
||||
- [ ] **CRITICAL-05**: 自动购包佣金链补全 — `AutoPurchaseHandler.ProcessTask()` 事务提交成功后入队 `TaskTypeCommission`
|
||||
- [ ] **CRITICAL-06**: 代购订单金额修正 — 场景 5(代理代购下级)`sellerCostPrice` 全部 6 处逐一审查,确保使用 `operatorCostPrice`(非 `buyerCostPrice`)
|
||||
- [x] **CRITICAL-06**: 代购订单金额修正 — 场景 5(代理代购下级)`sellerCostPrice` 全部 6 处逐一审查,确保使用 `operatorCostPrice`(非 `buyerCostPrice`)
|
||||
- [x] **CRITICAL-07**: 设备导入补充 IMEI 字段 — `DeviceRow` 新增 IMEI,`ParseDeviceExcel` 列名映射新增 IMEI,`device_import.go` 导入时填充
|
||||
- [x] **CRITICAL-08**: 提现冻结并发校验 — `my_commission/service.go` 冻结余额后检查 `RowsAffected == 0`,余额不足并发场景返回错误而非静默继续
|
||||
|
||||
@@ -125,7 +125,7 @@
|
||||
| CRITICAL-03 | Phase 1 | Pending |
|
||||
| CRITICAL-04 | Phase 1 | Pending |
|
||||
| CRITICAL-05 | Phase 1 | Pending |
|
||||
| CRITICAL-06 | Phase 1 | Pending |
|
||||
| CRITICAL-06 | Phase 1 | Complete |
|
||||
| CRITICAL-07 | Phase 1 | Complete |
|
||||
| CRITICAL-08 | Phase 1 | Complete |
|
||||
| PERM-01 | Phase 2 | Pending |
|
||||
|
||||
@@ -37,7 +37,7 @@ Plans:
|
||||
- [x] 01-01-PLAN.md — CRITICAL-01/02:实名状态常量统一 + C 端实名校验修复(Wave 1)
|
||||
- [ ] 01-02-PLAN.md — CRITICAL-03:实名激活任务断链(PollingHandler 注入 asynqClient)(Wave 2)
|
||||
- [ ] 01-03-PLAN.md — CRITICAL-04/05:充值回调触发自动购包 + 佣金链补全(Wave 2,parallel)
|
||||
- [ ] 01-04-PLAN.md — CRITICAL-06:代购订单 sellerCostPrice 6 处语义审查修正(Wave 1,parallel)
|
||||
- [x] 01-04-PLAN.md — CRITICAL-06:代购订单 sellerCostPrice 6 处语义审查修正(Wave 1,parallel)
|
||||
- [x] 01-05-PLAN.md — CRITICAL-07/08:设备导入 IMEI + 提现冻结并发校验(Wave 1,parallel)
|
||||
|
||||
---
|
||||
|
||||
@@ -3,12 +3,12 @@ gsd_state_version: 1.0
|
||||
milestone: v1.0
|
||||
milestone_name: milestone
|
||||
status: unknown
|
||||
last_updated: "2026-03-27T14:56:27.264Z"
|
||||
last_updated: "2026-03-27T15:25:28.566Z"
|
||||
progress:
|
||||
total_phases: 6
|
||||
completed_phases: 0
|
||||
total_plans: 5
|
||||
completed_plans: 2
|
||||
completed_plans: 3
|
||||
---
|
||||
|
||||
# Project State — 君鸿卡管系统
|
||||
@@ -22,7 +22,7 @@ progress:
|
||||
## Current Position
|
||||
|
||||
Phase: 01 (p0) — EXECUTING
|
||||
Plan: 3 of 5
|
||||
Plan: 2 of 5
|
||||
| Field | Value |
|
||||
|-------|-------|
|
||||
| **Current Phase** | 1 — P0 紧急修复 |
|
||||
@@ -73,6 +73,7 @@ Progress: [ 1 ]──[ 2 ]──[ 3 ]──[ 4 ]──[ 5 ]──[ 6 ]
|
||||
---
|
||||
| Phase 01-p0 P05 | 8 | 2 tasks | 3 files |
|
||||
| Phase 01-p0 P01 | 15 | 2 tasks | 7 files |
|
||||
| Phase 01-p0 P04 | 4min | 1 tasks | 1 files |
|
||||
|
||||
## Accumulated Context
|
||||
|
||||
|
||||
126
.planning/phases/01-p0/01-04-SUMMARY.md
Normal file
126
.planning/phases/01-p0/01-04-SUMMARY.md
Normal file
@@ -0,0 +1,126 @@
|
||||
---
|
||||
phase: 01-p0
|
||||
plan: "04"
|
||||
subsystem: order-service
|
||||
tags: [bug-fix, commission, seller-cost-price, critical]
|
||||
dependency_graph:
|
||||
requires: []
|
||||
provides: [CRITICAL-06]
|
||||
affects: [commission-calculation]
|
||||
tech_stack:
|
||||
added: []
|
||||
patterns: [semantic-review]
|
||||
key_files:
|
||||
created: []
|
||||
modified:
|
||||
- internal/service/order/service.go
|
||||
decisions:
|
||||
- "逐一语义审查 6 处 sellerCostPrice 赋值,仅修改场景 5(代理代购下级)三处,其余场景确认正确"
|
||||
- "scene5 赋值从 buyerCostPrice 改为 operatorCostPrice(操作方成本价),佣金差额计算基准正确"
|
||||
metrics:
|
||||
duration: "4min"
|
||||
completed_date: "2026-03-27"
|
||||
tasks_completed: 1
|
||||
files_changed: 1
|
||||
requirements: [CRITICAL-06]
|
||||
---
|
||||
|
||||
# Phase 01 Plan 04: sellerCostPrice 修正(CRITICAL-06)Summary
|
||||
|
||||
**一句话总结:** 修正三个下单函数中代理代购下级场景(scene 5)的 sellerCostPrice 赋值,由 buyerCostPrice(下级成本价)改为 operatorCostPrice(操作方自己成本价),佣金链差额计算恢复正常。
|
||||
|
||||
---
|
||||
|
||||
## 任务完成情况
|
||||
|
||||
| 任务 | 名称 | Commit | 状态 |
|
||||
|------|------|--------|------|
|
||||
| 1 | 逐一审查并修正 sellerCostPrice 6 处赋值 | f74b7da | ✅ 完成 |
|
||||
|
||||
---
|
||||
|
||||
## sellerCostPrice 6 处逐一审查结论
|
||||
|
||||
| # | 行号(修改后) | 所在函数/场景 | 操作方 | 资产归属 | 赋值 | 结论 |
|
||||
|---|-------------|-------------|--------|---------|------|------|
|
||||
| 1 | ~187 | 函数1(普通下单)/ 场景1:平台offline代购 | 平台 | 代理客户 | `buyerCostPrice`(代理成本价) | ✅ 正确:sellerCostPrice = 代理方成本价 |
|
||||
| 2 | ~234 | 函数1 / 子场景2.1:代理自购 | 代理 | 自己 | `costPrice`(自己成本价) | ✅ 正确:sellerCostPrice = 自己成本价 |
|
||||
| 3 | ~264 | 函数1 / 子场景2.2:**代理代购下级** | 代理 | 下级代理 | ~~buyerCostPrice~~ → **operatorCostPrice** | ⚠️ **已修正** |
|
||||
| 4 | ~474 | 函数2(后台下单)/ 子场景1.2:平台代购 | 平台 | 代理客户 | `buyerCostPrice`(代理成本价) | ✅ 正确:sellerCostPrice = 代理方成本价 |
|
||||
| 5 | ~551 | 函数2 / 子场景2.2:**代理代购下级** | 代理 | 下级代理 | ~~buyerCostPrice~~ → **operatorCostPrice** | ⚠️ **已修正** |
|
||||
| 6 | ~813 | 函数3(H5下单)/ 子场景2.2:**代理代购下级** | 代理 | 下级代理 | ~~buyerCostPrice~~ → **operatorCostPrice** | ⚠️ **已修正** |
|
||||
|
||||
> **注意**:规格书 A-5 提到"6 处 sellerCostPrice = buyerCostPrice",但实际代码中 `#2/#4` 已是 `costPrice`(自购场景),不是 `buyerCostPrice`。实际有 5 处 `sellerCostPrice = buyerCostPrice`(1+1+1+1+1),其中 3 处正确、3 处错误需修正。
|
||||
|
||||
---
|
||||
|
||||
## 修改前后代码对比
|
||||
|
||||
### 场景 5(三个函数相同结构,以函数1为例)
|
||||
|
||||
**修改前(错误):**
|
||||
```go
|
||||
// ==== 子场景 2.2:代理代购(给下级购买)====
|
||||
buyerCostPrice, _ := s.getCostPrice(ctx, *resourceShopID, firstPackageID) // 下级成本价
|
||||
operatorCostPrice, _ := s.getCostPrice(ctx, operatorShopID, firstPackageID) // 自己成本价
|
||||
|
||||
totalAmount = buyerCostPrice // 下级成本价作为面值(正确)
|
||||
actualPaidAmount = &operatorCostPrice // 实际扣自己钱包(正确)
|
||||
sellerCostPrice = buyerCostPrice // ← 错误!下级成本价和自己成本价相同,差额为 0
|
||||
```
|
||||
|
||||
**修改后(正确):**
|
||||
```go
|
||||
// 代理代购下级时,佣金差额基准应是操作方(代理自己)的成本价,而非下级的成本价
|
||||
sellerCostPrice = operatorCostPrice // ✅ 自己(代理)的成本价作为佣金差额基准
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## 编译验证
|
||||
|
||||
```
|
||||
go build ./... → 通过(无输出,无错误)
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## CRITICAL-06 完成状态
|
||||
|
||||
- [x] 6 处 sellerCostPrice 赋值全部经过语义审查
|
||||
- [x] 场景 5 三处(三个下单函数中各一处)已将 `sellerCostPrice = buyerCostPrice` 改为 `sellerCostPrice = operatorCostPrice`
|
||||
- [x] 其余各处审查结论已记录(见上表)
|
||||
- [x] `go build ./...` 编译通过
|
||||
- [x] 独立 commit 已提交(`f74b7da`)
|
||||
|
||||
---
|
||||
|
||||
## Deviations from Plan
|
||||
|
||||
### Auto-fixed Issues
|
||||
|
||||
无自动修正偏差,但有一处与规格书的差异说明:
|
||||
|
||||
**规格书描述:** "6 处 sellerCostPrice = buyerCostPrice" 需逐一审查,仅第 525-548 行的场景 5 有错。
|
||||
|
||||
**实际情况:** 代码中有三个独立的下单函数(普通/后台/H5),每个函数中都存在相同的场景 5 代理代购下级分支,各有一处错误赋值。三处全部修正,而非只修正规格书提到的一处。
|
||||
|
||||
**影响评估:** 修复更彻底,场景 5 的佣金链在三种下单入口均恢复正常。
|
||||
|
||||
---
|
||||
|
||||
## Known Stubs
|
||||
|
||||
无。
|
||||
|
||||
---
|
||||
|
||||
## Self-Check
|
||||
|
||||
- [x] `internal/service/order/service.go` — FOUND
|
||||
- [x] commit `f74b7da` — FOUND
|
||||
- [x] `sellerCostPrice = operatorCostPrice` 出现 3 次(三个函数各一处)— VERIFIED
|
||||
|
||||
## Self-Check: PASSED
|
||||
|
||||
### 检查修改文件
|
||||
Reference in New Issue
Block a user