全局审计完成

internal/service/iot_card/service.go

@@ -14,7 +14,6 @@ import (
 	"github.com/break/junhong_cmp_fiber/internal/model"
 	"github.com/break/junhong_cmp_fiber/internal/model/dto"
 	packageexpiry "github.com/break/junhong_cmp_fiber/internal/query/packageexpiry"
-	assetAuditSvc "github.com/break/junhong_cmp_fiber/internal/service/asset_audit"
 	"github.com/break/junhong_cmp_fiber/internal/store"
 	"github.com/break/junhong_cmp_fiber/internal/store/postgres"
 	"github.com/break/junhong_cmp_fiber/pkg/auditcontext"
@@ -68,7 +67,6 @@ type Service struct {
 	deviceSimBindingStore      *postgres.DeviceSimBindingStore
 	redis                      *redis.Client
 	assetIdentifierStore       *postgres.AssetIdentifierStore
-	assetAuditService          AssetAuditService
 	enterpriseCardAuthStore    *postgres.EnterpriseCardAuthorizationStore
 	enterpriseStore            *postgres.EnterpriseStore
 	packageExpiryQuery         *packageexpiry.Query
@@ -109,7 +107,6 @@ func New(
 	packageSeriesStore *postgres.PackageSeriesStore,
 	gatewayClient *gateway.Client,
 	logger *zap.Logger,
-	assetAuditService AssetAuditService,
 ) *Service {
 	return &Service{
 		db:                         db,
@@ -121,7 +118,6 @@ func New(
 		packageSeriesStore:         packageSeriesStore,
 		gatewayClient:              gatewayClient,
 		logger:                     logger,
-		assetAuditService:          assetAuditService,
 		packageExpiryQuery:         packageexpiry.NewQuery(db),
 	}
 }
@@ -1696,77 +1692,33 @@ func parseGatewayRealnameStatus(realStatus bool) int {
 func (s *Service) UpdatePollingStatus(ctx context.Context, cardID uint, enablePolling bool) error {
 	card, err := s.iotCardStore.GetByID(ctx, cardID)
 	if err != nil {
+		appErr := errors.Wrap(errors.CodeDatabaseError, err, "查询 IoT 卡失败")
+		result := constants.AuditResultFailed
 		if err == gorm.ErrRecordNotFound {
-			denyErr := errors.New(errors.CodeNotFound, "IoT卡不存在")
-			errorCode, errorMsg := assetAuditSvc.BuildErrorInfo(denyErr)
-			s.logCardAudit(ctx, assetAuditSvc.BuildLogParams{
-				OperationType:   constants.AssetAuditOpCardPollingStatus,
-				OperationDesc:   "更新卡轮询状态被拒绝",
-				ResultStatus:    constants.AssetAuditResultDenied,
-				ErrorCode:       errorCode,
-				ErrorMsg:        errorMsg,
-				AssetID:         cardID,
-				AssetIdentifier: "",
-				AfterData: map[string]any{
-					"enable_polling": enablePolling,
-				},
-			})
-			return denyErr
+			appErr = errors.New(errors.CodeNotFound, "IoT卡不存在")
+			result = constants.AuditResultDenied
 		}
-		errorCode, errorMsg := assetAuditSvc.BuildErrorInfo(err)
-		s.logCardAudit(ctx, assetAuditSvc.BuildLogParams{
-			OperationType: constants.AssetAuditOpCardPollingStatus,
-			OperationDesc: "更新卡轮询状态执行失败",
-			ResultStatus:  constants.AssetAuditResultFailed,
-			ErrorCode:     errorCode,
-			ErrorMsg:      errorMsg,
-			AssetID:       cardID,
-			AfterData: map[string]any{
-				"enable_polling": enablePolling,
-			},
-		})
+		s.recordPollingStatusFailure(ctx, constants.AuditActionIotCardPollingStatusUpdated, result, &model.IotCard{Model: gorm.Model{ID: cardID}}, enablePolling, appErr)
+		return appErr
+	}
+	beforePolling := card.EnablePolling
+	err = s.db.WithContext(ctx).Transaction(func(tx *gorm.DB) error {
+		if beforePolling != enablePolling {
+			result := tx.Model(&model.IotCard{}).Where("id = ? AND enable_polling = ?", card.ID, beforePolling).Update("enable_polling", enablePolling)
+			if result.Error != nil {
+				return errors.Wrap(errors.CodeDatabaseError, result.Error, "更新 IoT 卡轮询状态失败")
+			}
+			if result.RowsAffected == 0 {
+				return errors.New(errors.CodeConflict, "轮询状态已变更，请刷新后重试")
+			}
+		}
+		return s.appendPollingStatusAudit(ctx, tx, card, beforePolling, enablePolling)
+	})
+	if err != nil {
+		s.recordPollingStatusFailure(ctx, constants.AuditActionIotCardPollingStatusUpdated, constants.AuditResultFailed, card, enablePolling, err)
 		return err
 	}
-
-	// 检查是否需要更新
-	if card.EnablePolling == enablePolling {
-		s.logCardAudit(ctx, assetAuditSvc.BuildLogParams{
-			OperationType:   constants.AssetAuditOpCardPollingStatus,
-			OperationDesc:   "更新卡轮询状态",
-			ResultStatus:    constants.AssetAuditResultSuccess,
-			AssetID:         card.ID,
-			AssetIdentifier: card.ICCID,
-			BeforeData: map[string]any{
-				"enable_polling": card.EnablePolling,
-			},
-			AfterData: map[string]any{
-				"enable_polling": enablePolling,
-			},
-		})
-		return nil // 状态未变化
-	}
-
-	// 更新数据库
 	card.EnablePolling = enablePolling
-	if err := s.iotCardStore.Update(ctx, card); err != nil {
-		errorCode, errorMsg := assetAuditSvc.BuildErrorInfo(err)
-		s.logCardAudit(ctx, assetAuditSvc.BuildLogParams{
-			OperationType:   constants.AssetAuditOpCardPollingStatus,
-			OperationDesc:   "更新卡轮询状态执行失败",
-			ResultStatus:    constants.AssetAuditResultFailed,
-			ErrorCode:       errorCode,
-			ErrorMsg:        errorMsg,
-			AssetID:         card.ID,
-			AssetIdentifier: card.ICCID,
-			BeforeData: map[string]any{
-				"enable_polling": !enablePolling,
-			},
-			AfterData: map[string]any{
-				"enable_polling": enablePolling,
-			},
-		})
-		return err
-	}
 
 	s.logger.Info("更新卡轮询状态",
 		zap.Uint("card_id", cardID),
@@ -1782,20 +1734,6 @@ func (s *Service) UpdatePollingStatus(ctx context.Context, cardID uint, enablePo
 		}
 	}
 
-	s.logCardAudit(ctx, assetAuditSvc.BuildLogParams{
-		OperationType:   constants.AssetAuditOpCardPollingStatus,
-		OperationDesc:   "更新卡轮询状态",
-		ResultStatus:    constants.AssetAuditResultSuccess,
-		AssetID:         card.ID,
-		AssetIdentifier: card.ICCID,
-		BeforeData: map[string]any{
-			"enable_polling": !enablePolling,
-		},
-		AfterData: map[string]any{
-			"enable_polling": enablePolling,
-		},
-	})
-
 	return nil
 }
 
@@ -1805,23 +1743,17 @@ func (s *Service) BatchUpdatePollingStatus(ctx context.Context, cardIDs []uint,
 		return nil
 	}
 
-	// 批量更新数据库
-	if err := s.iotCardStore.BatchUpdatePollingStatus(ctx, cardIDs, enablePolling); err != nil {
-		errorCode, errorMsg := assetAuditSvc.BuildErrorInfo(err)
-		s.logCardAudit(ctx, assetAuditSvc.BuildLogParams{
-			OperationType: constants.AssetAuditOpCardPollingStatus,
-			OperationDesc: "批量更新卡轮询状态执行失败",
-			ResultStatus:  constants.AssetAuditResultFailed,
-			ErrorCode:     errorCode,
-			ErrorMsg:      errorMsg,
-			BatchTotal:    len(cardIDs),
-			FailCount:     len(cardIDs),
-			AfterData: map[string]any{
-				"card_ids":       cardIDs,
-				"enable_polling": enablePolling,
-				"trigger_source": "batch",
-			},
-		})
+	cards, err := s.iotCardStore.GetByIDs(ctx, cardIDs)
+	if err != nil {
+		return err
+	}
+	err = s.db.WithContext(ctx).Transaction(func(tx *gorm.DB) error {
+		if updateErr := tx.Model(&model.IotCard{}).Where("id IN ?", cardIDs).Update("enable_polling", enablePolling).Error; updateErr != nil {
+			return errors.Wrap(errors.CodeDatabaseError, updateErr, "批量更新 IoT 卡轮询状态失败")
+		}
+		return s.appendBatchPollingStatusAudit(ctx, tx, cards, enablePolling)
+	})
+	if err != nil {
 		return err
 	}
 
@@ -1841,19 +1773,6 @@ func (s *Service) BatchUpdatePollingStatus(ctx context.Context, cardIDs []uint,
 		}
 	}
 
-	s.logCardAudit(ctx, assetAuditSvc.BuildLogParams{
-		OperationType: constants.AssetAuditOpCardPollingStatus,
-		OperationDesc: "批量更新卡轮询状态",
-		ResultStatus:  constants.AssetAuditResultSuccess,
-		BatchTotal:    len(cardIDs),
-		SuccessCount:  len(cardIDs),
-		AfterData: map[string]any{
-			"card_ids":       cardIDs,
-			"enable_polling": enablePolling,
-			"trigger_source": "batch",
-		},
-	})
-
 	return nil
 }